Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44066: [Python] Add Python wrapper for JsonExtensionType #44070
base: main
Are you sure you want to change the base?
GH-44066: [Python] Add Python wrapper for JsonExtensionType #44070
Changes from all commits
4d591e5
60eda4a
1ba3ba7
94006f9
e522efb
b1e9241
4806d9f
77c964b
3364c0f
b2bca96
fdf8fb6
99d8ca7
6dff127
647a2ef
98aade9
bcffa48
1be8605
2c17b92
66de612
1022a2a
0352b38
586bd5b
ea75cdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this means that the storage type is not taken into account for checking equality of the JSON extension type? Should it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to test that
pa.json_()
sets storage topa.utf8()
by default and I'd keep this test. However as noted in #13901 (review) disregarding storage type here is not desirable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes of course, that's good to test