Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44222: [C++][Gandiva] Accept LLVM 19.1 #44233

Merged
merged 3 commits into from
Sep 27, 2024
Merged

GH-44222: [C++][Gandiva] Accept LLVM 19.1 #44233

merged 3 commits into from
Sep 27, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 25, 2024

Rationale for this change

LLVM 19.1.0 was released.

What changes are included in this PR?

Accept LLVM 19.1.0.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Sep 25, 2024

@github-actions crossbow submit -g cpp

Copy link

⚠️ GitHub issue #44222 has been automatically assigned in GitHub to PR creator.

Copy link

Revision: 96be329

Submitted crossbow builds: ursacomputing/crossbow @ actions-b5508a5d51

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@kou
Copy link
Member Author

kou commented Sep 26, 2024

@github-actions crossbow submit java-jars

Copy link

Revision: 96be329

Submitted crossbow builds: ursacomputing/crossbow @ actions-88a671c085

Task Status
java-jars GitHub Actions

@kou
Copy link
Member Author

kou commented Sep 26, 2024

+1

AppVeyor failure is GH-44234.

@vibhatha
Copy link
Collaborator

@kou I recently disabled some tests in Gandiva because of the issue mentioned here #43981

Do you think re-enabling and testing would be a feasible idea with this change?

cc @lidavidm

@lidavidm
Copy link
Member

@kou I recently disabled some tests in Gandiva because of the issue mentioned here #43981

Do you think re-enabling and testing would be a feasible idea with this change?

cc @lidavidm

Let's just leave it IMO, I hope the Gandiva maintainers can step back up to reenable the tests

@kou
Copy link
Member Author

kou commented Sep 27, 2024

We can work on re-enabling them as a separated PR.
This can fix existing CI failures.

I'll merge this.

@kou kou merged commit 3505457 into apache:main Sep 27, 2024
33 of 35 checks passed
@kou kou deleted the cpp-llvm-19 branch September 27, 2024 01:34
@kou kou removed the awaiting committer review Awaiting committer review label Sep 27, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3505457.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants