AVRO-3171 JS: fix test failures on Node.js 16 #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Node.js to the GitHub Actions workflow
martin-g
commented
Oct 6, 2021
| @@ -1099,6 +1099,8 @@ MessageDecoder.prototype._flush = function () { | |||
| this.emit('error', new Error('trailing data')); | |||
| } else if (this._empty) { | |||
| this.emit('error', new Error('no message decoded')); | |||
| } else { | |||
| this.emit('finish'); | |||
There was a problem hiding this comment.
This fixes the issue with Node.js 16 but it is a mystery to me why finish event is not emitted automatically on the Transform stream after the reabable.end().
|
I've pinged Node.js devs about this issue: nodejs/node#39332 (comment) |
|
Thanks for the contribution! |
RyanSkraba
pushed a commit
that referenced
this pull request
Oct 13, 2021
Add Node.js to the GitHub Actions workflow
|
I've cherry-picked this into branch-1.11 so it should appear in the next 1.11.0 release candidate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Node.js to the GitHub Actions workflow
Jira
Tests
Commits