Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3838: [Rust] Replace "regex" with "regex-lite" #2460

Merged
merged 1 commit into from
Aug 22, 2023
Merged

AVRO-3838: [Rust] Replace "regex" with "regex-lite" #2460

merged 1 commit into from
Aug 22, 2023

Conversation

martin-g
Copy link
Member

AVRO-3838

Reduces the time for `cargo clean && cargo build --release" from 30secs to 22secs on my dev machine

What is the purpose of the change

  • Improve the build times by around 30%

Verifying this change

  • All unit tests should still pass

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the Rust label Aug 21, 2023
@martin-g martin-g marked this pull request as ready for review August 21, 2023 08:21
@martin-g martin-g requested a review from clesaec August 21, 2023 08:21
@martin-g
AVRO-3838: [Rust] Replace "regex" with "regex-lite"
96fef15 
Reduces the time for `cargo clean && cargo build --release" from 30secs
to 22secs on my dev machine

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Member Author

@sarutak You might be interested in this PR too.

@sarutak
Copy link
Member

sarutak commented Aug 21, 2023

@martin-g Thank you for letting me know. I'll check it soon.

sarutak
sarutak approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-g martin-g merged commit 0f364e3 into master Aug 22, 2023
15 checks passed
@martin-g martin-g deleted the avro-3838-use-regex-lite branch August 22, 2023 07:11
martin-g added a commit that referenced this pull request Aug 22, 2023
@martin-g
AVRO-3838: [Rust] Replace "regex" with "regex-lite" (#2460)
14b9330 
Reduces the time for `cargo clean && cargo build --release" from 30secs
to 22secs on my dev machine

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
(cherry picked from commit 0f364e3)
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
@martin-g
AVRO-3838: [Rust] Replace "regex" with "regex-lite" (apache#2460)
1fe4202 
Reduces the time for `cargo clean && cargo build --release" from 30secs
to 22secs on my dev machine

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarutak sarutak sarutak approved these changes

@clesaec clesaec Awaiting requested review from clesaec

Assignees
No one assigned
Labels
Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-g @sarutak