Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins,Spark] Stop running Nexmark suite for deprecated Spark 2 runners #23639

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

mosche
Copy link
Member

@mosche mosche commented Oct 14, 2022

The Nexmark SparkStructuredStreamingRunner v2 and v3 tests are currently both publishing results to the same metric, the same issue applies to the "normal" SparkRunner.

Stop running Nexmark suite for deprecated Spark 2 runners.
Additionally, following the approach taken for Flink, this ensures a consistent version of Spark is used for Nexmark tests (fixes #23634).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

…ner and ensure consistent version of Spark is used for Nexmark tests (fixes apache#23634)
@mosche mosche force-pushed the 23634_nexmark_spark_version branch from 63f410e to c2aa228 Compare October 14, 2022 09:24
@mosche
Copy link
Member Author

mosche commented Oct 14, 2022

R: @apilloud
R: @aromanenko-dev
R: @echauchot

@mosche
Copy link
Member Author

mosche commented Oct 14, 2022

Note, besides being deprecated, it also turns out the Spark 2 runners are completely broken. The version of Jackson Beam requires is not compatible with the one available / loaded on a Spark 2 cluster. Due to that deserialization of PipelineOptions fails.
#23568

@github-actions github-actions bot added the infra label Oct 14, 2022
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev
Copy link
Contributor

Run Seed Job

@aromanenko-dev
Copy link
Contributor

Run Spark Runner Nexmark Tests

@aromanenko-dev aromanenko-dev merged commit 690f351 into apache:master Oct 17, 2022
@mosche mosche deleted the 23634_nexmark_spark_version branch November 9, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nexmark SparkStructuredStreamingRunner v2 and v3 publishing to same metric
3 participants