Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies needed for some ml integration tests #25548

Closed
wants to merge 2 commits into from
Closed

Add dependencies needed for some ml integration tests #25548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45793df
Add dependencies needed for some ml integration tests
damccorm Feb 17, 2023
fccffaf
Port change from #25496
damccorm Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,20 @@ def get_portability_package_data():
'pyyaml>=3.12,<7.0.0',
'requests_mock>=1.7,<2.0',
'tenacity>=5.0.2,<6.0',
'onnxruntime==1.13.1',
'Pillow>=9.0.0',
'pytest>=7.1.2,<8.0',
'pytest-xdist>=2.5.0,<3',
'pytest-timeout>=2.1.0,<3',
'scikit-learn>=0.20.0',
'skl2onnx==1.13',
'sqlalchemy>=1.3,<2.0',
'tensorflow>=2.11.0,<3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add these in the test?

Initially, there was a disagreement of adding ML libraries to the apache_beam[test], as it could install lot of unncessary dependencies and also big in size(tensorflow, torch) on to the user machine.

Also, I am removing tensorflow from the python/containers/base_image_requirements_manual.txt since it is blocking the upgrade of protobuf.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of adding these dependencies to the respective gradle/tox tasks.

'tensorflow_hub>=0.10.0',
'tf2onnx==1.13.0',
'torch>=1.7.1',
'torchvision>=0.8.2',
'transformers>=4.18.0',
'psycopg2-binary>=2.8.5,<3.0.0',
'testcontainers[mysql]>=3.0.3,<4.0.0',
'cryptography>=36.0.0',
Expand Down
3 changes: 1 addition & 2 deletions sdks/python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,7 @@ commands =
/bin/sh -c "pip freeze | grep -E onnx"
# Run all ONNX unit tests
pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_onnx {posargs}

[testenv:py{37,38,39,310}-tf-{211}]

[testenv:py{37,38,39,310}-tensorflow-{29,210,211}]
deps =
-r build-requirements.txt
Expand Down