-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colab Notebook Integration Tests #26690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26690 +/- ##
==========================================
- Coverage 81.07% 80.94% -0.13%
==========================================
Files 469 471 +2
Lines 67199 67629 +430
==========================================
+ Hits 54483 54745 +262
- Misses 12716 12884 +168
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 59 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python_Colab PreCommit |
R: @liferoad |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
R: @damccorm |
|
||
|
||
def _skip_test(spec): | ||
if IS_BEAM_DEV and "sql" in str(spec).lower(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one more nit, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll merge once CI completes
* Draft * remove upper bound on 'nbformat' and 'nbconvert' * remove upper bound on 'nbformat' and 'nbconvert' * lint * setup.py dependency * move files * move files * change test trigger * edits * edits * edits
* Draft * remove upper bound on 'nbformat' and 'nbconvert' * remove upper bound on 'nbformat' and 'nbconvert' * lint * setup.py dependency * move files * move files * change test trigger * edits * edits * edits
* Draft * remove upper bound on 'nbformat' and 'nbconvert' * remove upper bound on 'nbformat' and 'nbconvert' * lint * setup.py dependency * move files * move files * change test trigger * edits * edits * edits
* Draft * remove upper bound on 'nbformat' and 'nbconvert' * remove upper bound on 'nbformat' and 'nbconvert' * lint * setup.py dependency * move files * move files * change test trigger * edits * edits * edits
Fixes #26604.
This PR adds a script to test the cells output, and compare it to a
.spec
file that will need to be provided in Colab submission PRs. This PR also adds a presubmit check to ensure this on Jenkins.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.