Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KinesisIO throwing NullPointerException when progress check made before starting reader #26953

Merged
merged 1 commit into from
May 31, 2023

Conversation

zhoufek
Copy link
Contributor

@zhoufek zhoufek commented May 31, 2023

fixes #23868

This has the KinesisReader return unknown if it cannot determine the backlog size due to the start method not previously being called. The progress check can happen at arbitrary times, so it must be accounted for here.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@zhoufek zhoufek marked this pull request as ready for review May 31, 2023 18:40
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

Is it valid to try and get the backlog without having started the reader? Whats the actual scenario here?

The fix looks fine

@zhoufek
Copy link
Contributor Author

zhoufek commented May 31, 2023

Part of the stack trace of the issue is:

...
Caused by: java.lang.NullPointerException
        at org.apache.beam.sdk.io.kinesis.KinesisReader.getSplitBacklogBytes(KinesisReader.java:172)
        at org.apache.beam.sdk.io.Read$UnboundedSourceAsSDFWrapperFn$UnboundedSourceAsSDFRestrictionTracker.getProgress(Read.java:983)
        at org.apache.beam.sdk.transforms.reflect.ByteBuddyDoFnInvokerFactory$DefaultGetSize.invokeGetSize(ByteBuddyDoFnInvokerFactory.java:431)
...

From talking with Cham, it sounds like getProgress can be called at arbitrary times, including before reading starts, and in that case, we should just report no progress.

@johnjcasey
Copy link
Contributor

makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: apache_beam.io.kinesis.ReadDataFromKinesis UserCodeException
2 participants