Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestContainerResourceManager for third party resources. #27642

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

pranavbhandari24
Copy link
Contributor

@pranavbhandari24 pranavbhandari24 commented Jul 24, 2023

Add TestContainer Resource manager for third-party resources.
All third-party resources will be created using test containers for Integration/Load tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Jul 24, 2023
@pranavbhandari24
Copy link
Contributor Author

R: @kennknowles, @johnjcasey, @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #27642 (bad5b3f) into master (8afaa65) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27642      +/-   ##
==========================================
- Coverage   71.10%   71.09%   -0.02%     
==========================================
  Files         859      859              
  Lines      104544   104555      +11     
==========================================
- Hits        74335    74331       -4     
- Misses      28652    28667      +15     
  Partials     1557     1557              
Flag Coverage Δ
python 80.27% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It's nice that this one has checkStyle cleaned also

@Abacn Abacn merged commit 5838efd into apache:master Jul 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants