Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to specific transformers version #27736

Closed
wants to merge 3 commits into from

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jul 28, 2023

Some framework/model combos are not compatible across transform versions (e.g. see #27647). We should pin to a single version in our examples and our tests to avoid loading issues as versions increase. This will also model the recommended behavior for customers. Over time we can consider bumping these versions as well, it will require retraining our models though.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

Run Inference Benchmarks

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #27736 (dd3d7b4) into master (9919d5a) will increase coverage by 0.00%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #27736   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files         860      860           
  Lines      104631   104635    +4     
=======================================
+ Hits        74173    74177    +4     
  Misses      28904    28904           
  Partials     1554     1554           
Flag Coverage Δ
python 80.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Run Inference Benchmarks

@damccorm damccorm closed this Jul 31, 2023
@damccorm damccorm deleted the users/damccorm/pinTransformers branch August 17, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant