-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers #28036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28036 +/- ##
==========================================
- Coverage 72.31% 72.31% -0.01%
==========================================
Files 678 678
Lines 99744 99744
==========================================
- Hits 72127 72125 -2
- Misses 26057 26059 +2
Partials 1560 1560
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdks/python/container/Dockerfile
Outdated
@@ -80,6 +80,11 @@ RUN \ | |||
# Remove pip cache. | |||
rm -rf /root/.cache/pip | |||
|
|||
# Required for using Beam Python SDK on ARM machines. | |||
RUN if [ "${TARGETARCH}" = "arm64" ] ; then \ | |||
apt-get install libgeos-dev ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would suggest to move these statements to line 42 (keeping the statements inside one RUN command). note that apt temp files are cleared in line 44, and this command might require a prior call to apt update
.
Also, did you run validatesconainerarm tests to verify this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, did you run validatesconainerarm tests to verify this change ?
you could post a link to GHA run on the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, pr intent looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tried to put it around line 42 earlier but I don't think the if condition can be inserted between different package names after calling apt-get install.
- I can't run on this branch because it is just a fork of the apache/beam master not the original master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I think we can install unconditionally to avoid extra complexity. I suspect it current version might fail without apt update.
Run Python ValidatesContainer Dataflow ARM 3.11 |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Python ValidatesContainer Dataflow ARM 3.11 |
LGTM |
… Beam SDK Python containers (#28112) * Add libgeos-dev for ARM * remove double command * Try format fix * fix format * fix == * revert changes to follow convention * formatting * Fix package not found error. * install the package regardless --------- Co-authored-by: Celeste Zeng <61256376+celeste-zeng@users.noreply.github.com>
fixes: #28035
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.