Fix #1918 to add a integration test with camel-jdbc and camel-jms #2272

zhfeng · 2021-02-19T05:49:31Z

No description provided.

jamesnetherton

@zhfeng thanks for this. I left one comment for a small thing to tidy up. Otherwise LGTM.

jamesnetherton · 2021-02-22T07:17:37Z

integration-tests/jta/pom.xml

@@ -108,6 +142,7 @@
            </activation>
            <properties>
                <quarkus.package.type>native</quarkus.package.type>
+                <quarkus.native.additional-build-args>--report-unsupported-elements-at-runtime</quarkus.native.additional-build-args>


I guess we can remove this if it's just for debugging purposes.

No, it will throw some fatal analyist erros when building the images if removing this option. And I have no idea how to resolve them.

[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on GraalVM Version 20.3.0 (Java Version 11.0.9+10-jvmci-20.3-b06) [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] /home/zhfeng/Applications/graalvm-ce-java11-20.3.0/bin/native-image -J-DCoordinatorEnvironmentBean.transactionStatusManagerEnable=false -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=1 -J-Duser.language=zh -J-Duser.country=CN -J-Dfile.encoding=UTF-8 --initialize-at-build-time= -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy\$BySpaceAndTime -H:+JNI -H:+AllowFoldMethods -jar camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner.jar -H:FallbackThreshold=0 -H:+ReportExceptionStackTraces -H:-AddAllCharsets -H:EnableURLProtocols=http,https --enable-all-security-services -H:NativeLinkerOption=-no-pie --no-server -H:-UseServiceLoaderFeature -H:+StackTrace camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] classlist: 4,077.03 ms, 1.19 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] (cap): 663.98 ms, 1.19 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] setup: 2,253.91 ms, 1.19 GB 20:35:56,403 INFO [org.jbo.threads] JBoss Threads version 3.2.0.Final [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] (clinit): 1,205.38 ms, 4.75 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] (typeflow): 22,947.58 ms, 4.75 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] (objects): 28,066.73 ms, 4.75 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] (features): 1,213.41 ms, 4.75 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:360709] analysis: 56,323.29 ms, 4.75 GB Error: com.oracle.svm.hosted.substitute.DeletedElementException: Unsupported type jdk.internal.reflect.MethodAccessorGenerator is reachable To diagnose the issue, you can add the option --report-unsupported-elements-at-runtime. The unsupported element is then reported at run time when it is accessed the first time. Detailed message: Trace: at parsing jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) Call path from entry point to jdk.internal.reflect.ReflectionFactory.generateConstructor(Class, Constructor): at jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) at jdk.internal.reflect.ReflectionFactory.newConstructorForSerialization(ReflectionFactory.java:506) at java.io.ObjectStreamClass.getSerializableConstructor(ObjectStreamClass.java:1531) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:509) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:484) at com.oracle.svm.core.jdk.Target_java_security_AccessController.doPrivileged(SecuritySubstitutions.java:84) at sun.security.pkcs11.SunPKCS11.initToken(SunPKCS11.java:1028) at sun.security.pkcs11.SunPKCS11$TokenPoller.run(SunPKCS11.java:852) at java.lang.Thread.run(Thread.java:834) at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:519) at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:192) at com.oracle.svm.core.code.IsolateEnterStub.PosixJavaThreads_pthreadStartRoutine_e1f4a8c0039f8337338252cd8734f63a79b5e3df(generated:0) com.oracle.svm.core.util.UserError$UserException: com.oracle.svm.hosted.substitute.DeletedElementException: Unsupported type jdk.internal.reflect.MethodAccessorGenerator is reachable To diagnose the issue, you can add the option --report-unsupported-elements-at-runtime. The unsupported element is then reported at run time when it is accessed the first time. Detailed message: Trace: at parsing jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) Call path from entry point to jdk.internal.reflect.ReflectionFactory.generateConstructor(Class, Constructor): at jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) at jdk.internal.reflect.ReflectionFactory.newConstructorForSerialization(ReflectionFactory.java:506) at java.io.ObjectStreamClass.getSerializableConstructor(ObjectStreamClass.java:1531) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:509) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:484) at com.oracle.svm.core.jdk.Target_java_security_AccessController.doPrivileged(SecuritySubstitutions.java:84) at sun.security.pkcs11.SunPKCS11.initToken(SunPKCS11.java:1028) at sun.security.pkcs11.SunPKCS11$TokenPoller.run(SunPKCS11.java:852) at java.lang.Thread.run(Thread.java:834) at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:519) at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:192) at com.oracle.svm.core.code.IsolateEnterStub.PosixJavaThreads_pthreadStartRoutine_e1f4a8c0039f8337338252cd8734f63a79b5e3df(generated:0) at com.oracle.svm.core.util.UserError.abort(UserError.java:82) at com.oracle.svm.hosted.FallbackFeature.reportAsFallback(FallbackFeature.java:217) at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:768) at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:558) at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:471) at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1407) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) Caused by: com.oracle.graal.pointsto.constraints.UnsupportedFeatureException: com.oracle.svm.hosted.substitute.DeletedElementException: Unsupported type jdk.internal.reflect.MethodAccessorGenerator is reachable To diagnose the issue, you can add the option --report-unsupported-elements-at-runtime. The unsupported element is then reported at run time when it is accessed the first time. Detailed message: Trace: at parsing jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) Call path from entry point to jdk.internal.reflect.ReflectionFactory.generateConstructor(Class, Constructor): at jdk.internal.reflect.ReflectionFactory.generateConstructor(ReflectionFactory.java:513) at jdk.internal.reflect.ReflectionFactory.newConstructorForSerialization(ReflectionFactory.java:506) at java.io.ObjectStreamClass.getSerializableConstructor(ObjectStreamClass.java:1531) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:509) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:484) at com.oracle.svm.core.jdk.Target_java_security_AccessController.doPrivileged(SecuritySubstitutions.java:84) at sun.security.pkcs11.SunPKCS11.initToken(SunPKCS11.java:1028) at sun.security.pkcs11.SunPKCS11$TokenPoller.run(SunPKCS11.java:852) at java.lang.Thread.run(Thread.java:834) at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:519) at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:192) at com.oracle.svm.core.code.IsolateEnterStub.PosixJavaThreads_pthreadStartRoutine_e1f4a8c0039f8337338252cd8734f63a79b5e3df(generated:0) at com.oracle.graal.pointsto.constraints.UnsupportedFeatures.report(UnsupportedFeatures.java:126) at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:765) ... 8 more Caused by: com.oracle.svm.hosted.substitute.DeletedElementException: Unsupported type jdk.internal.reflect.MethodAccessorGenerator is reachable To diagnose the issue, you can add the option --report-unsupported-elements-at-runtime. The unsupported element is then reported at run time when it is accessed the first time. at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.lookup(AnnotationSubstitutionProcessor.java:119) at com.oracle.graal.pointsto.infrastructure.SubstitutionProcessor$ChainedSubstitutionProcessor.lookup(SubstitutionProcessor.java:113) at com.oracle.graal.pointsto.infrastructure.SubstitutionProcessor$ChainedSubstitutionProcessor.lookup(SubstitutionProcessor.java:113) at com.oracle.graal.pointsto.meta.AnalysisUniverse.lookupAllowUnresolved(AnalysisUniverse.java:207) at com.oracle.graal.pointsto.infrastructure.WrappedConstantPool.lookupType(WrappedConstantPool.java:164) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.lookupType(BytecodeParser.java:4250) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.genNewInstance(BytecodeParser.java:4565) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.processBytecode(BytecodeParser.java:5363) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.iterateBytecodesForBlock(BytecodeParser.java:3399) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.processBlock(BytecodeParser.java:3206) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.build(BytecodeParser.java:1092) at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.buildRootMethod(BytecodeParser.java:986) at jdk.internal.vm.compiler/org.graalvm.compiler.java.GraphBuilderPhase$Instance.run(GraphBuilderPhase.java:84) at com.oracle.svm.hosted.phases.SharedGraphBuilderPhase.run(SharedGraphBuilderPhase.java:70) at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.run(Phase.java:49) at jdk.internal.vm.compiler/org.graalvm.compiler.phases.BasePhase.apply(BasePhase.java:212) at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.apply(Phase.java:42) at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.apply(Phase.java:38) at com.oracle.graal.pointsto.flow.MethodTypeFlowBuilder.parse(MethodTypeFlowBuilder.java:223) at com.oracle.graal.pointsto.flow.MethodTypeFlowBuilder.apply(MethodTypeFlowBuilder.java:357) at com.oracle.graal.pointsto.flow.MethodTypeFlow.doParse(MethodTypeFlow.java:313) at com.oracle.graal.pointsto.flow.MethodTypeFlow.ensureParsed(MethodTypeFlow.java:302) at com.oracle.graal.pointsto.flow.MethodTypeFlow.addContext(MethodTypeFlow.java:103) at com.oracle.graal.pointsto.DefaultAnalysisPolicy$DefaultSpecialInvokeTypeFlow.onObservedUpdate(DefaultAnalysisPolicy.java:368) at com.oracle.graal.pointsto.flow.TypeFlow.notifyObservers(TypeFlow.java:470) at com.oracle.graal.pointsto.flow.TypeFlow.update(TypeFlow.java:542) at com.oracle.graal.pointsto.BigBang$2.run(BigBang.java:547) at com.oracle.graal.pointsto.util.CompletionExecutor.lambda$execute$0(CompletionExecutor.java:173) at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1426) ... 5 more Error: Image build request failed with exit status 1

Maybe we can check it again if quarkusio/quarkus#14871 get resolved in artemis extension ?

aldettinger · 2021-02-22T10:40:11Z

...ests/jta/src/test/java/org/apache/camel/quarkus/component/jta/it/ActiveMQXATestResource.java

+
+            container.start();
+
+            String brokerUrlTcp = String.format("tcp://127.0.0.1:%d/", container.getMappedPort(ACTIVEMQ_PORT));


"127.0.0.1" is hard coded. Would it make sense to replace with container.getContainerIpAddress() ?

yeah, good ponit !

aldettinger · 2021-02-22T10:45:04Z

integration-tests/jta/pom.xml

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-resteasy</artifactId>
        </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-jackson</artifactId>


I wonder where quarkus-jackson is needed ? Maybe we could remove it ?

It throw the exception when building native image if we remove quarkus-jackson.

[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on GraalVM Version 20.3.0 (Java Version 11.0.9+10-jvmci-20.3-b06) [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] /home/zhfeng/Applications/graalvm-ce-java11-20.3.0/bin/native-image -J-DCoordinatorEnvironmentBean.transactionStatusManagerEnable=false -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=1 -J-Duser.language=zh -J-Duser.country=CN -J-Dfile.encoding=UTF-8 --report-unsupported-elements-at-runtime --initialize-at-build-time= -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy\$BySpaceAndTime -H:+JNI -H:+AllowFoldMethods -jar camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner.jar -H:FallbackThreshold=0 -H:+ReportExceptionStackTraces -H:-AddAllCharsets -H:EnableURLProtocols=http,https --enable-all-security-services -H:NativeLinkerOption=-no-pie --no-server -H:-UseServiceLoaderFeature -H:+StackTrace camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:362449] classlist: 4,085.67 ms, 1.69 GB [camel-quarkus-integration-test-jta-1.7.0-SNAPSHOT-runner:362449] setup: 610.91 ms, 1.69 GB Fatal error:java.lang.NoClassDefFoundError at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:603) at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1006) at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:483) at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:350) at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:509) at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:115) at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:541) Caused by: java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/JsonSerializer at java.base/java.lang.Class.getDeclaredMethods0(Native Method) at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3166) at java.base/java.lang.Class.getDeclaredMethods(Class.java:2309) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleDeletedClass(AnnotationSubstitutionProcessor.java:512) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleClass(AnnotationSubstitutionProcessor.java:305) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.init(AnnotationSubstitutionProcessor.java:265) at com.oracle.svm.hosted.NativeImageGenerator.createDeclarativeSubstitutionProcessor(NativeImageGenerator.java:921) at com.oracle.svm.hosted.NativeImageGenerator.setupNativeImage(NativeImageGenerator.java:855) at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:556) at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:471) at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1407) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.databind.JsonSerializer at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) ... 16 more Error: Image build request failed with exit status 1

This needs to be resolved before merging. Could you please try with Quarkus master and GraalVM 21? I guess this fix of @JiriOndrusek might solve the root cause.

Sure, I will try.

This needs to be resolved before merging. Could you please try with Quarkus master and GraalVM 21? I guess this fix of @JiriOndrusek might solve the root cause.

Ups, sorry, this comment belonged above where the removal of <quarkus.native.additional-build-args>--report-unsupported-elements-at-runtime</quarkus.native.additional-build-args> was discussed.

No problem. I found the similar issue oracle/graal#2192 and I'm investigating to find the root cause of the analysis errors.

This fix in Quarkus master really might help quarkusio/quarkus#15043 Plz try with Quarkus master and GraalVM 21

yeah, it looks like Quarkus 1.12.0.Final has included this fix and I'm downloading GraalVM 21.0.0.2 to check.

Good to know. @JiriOndrusek then we can target #2254 back at camel quarkus master.

Great news that it works with GraalVM 21.0.0.2, Thanks @ppalaga !

aldettinger

I've shared some minor questions. This PR is a nice addition, well done @zhfeng 👍

zhfeng · 2021-02-22T12:55:30Z

Thanks every one for reviewing and I just upate with @aldettinger suggestion to replace with container.getContainerIpAddress() and leave a comment to check the --report-unsupported-elements-at-runtime in the future.

ppalaga · 2021-02-22T13:04:58Z

integration-tests/jta/pom.xml

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-resteasy</artifactId>
        </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-jackson</artifactId>


This needs to be resolved before merging. Could you please try with Quarkus master and GraalVM 21? I guess this fix of @JiriOndrusek might solve the root cause.

zhfeng · 2021-02-23T12:51:15Z

OK, I just find the root cause is from org.h2.jdbcx.JdbcDataSource.readObject() which is de-serializing the object by using ObjectStreamClass eventually. So I update to introduce artemis-jms-xa extension as a work around to support XA connection until quarkusio/quarkus#14871 get resolved. In the term of the h2 issue, I just use

@TargetClass(className = "org.h2.jdbcx.JdbcDataSource")
final class Target_org_h2_jdbcx_JdbcDataSource {
    @Delete
    private void readObject(ObjectInputStream in) {
    }
}

And I think this might be fixed in the quarkus h2-jdbc extension. I will raise an issue in quarkus.

Finally with these changes, we can remove --report-unsupported-elements-at-runtime and dependency of quarkus-jackson.

zhfeng · 2021-02-23T15:38:52Z

Well, all of these changes work fine with GraalVM 21.

ppalaga

Nice work, @zhfeng, thanks a lot!

jamesnetherton · 2021-02-24T08:46:52Z

Since I had to fix up something on the quarkus-master branch I have manually merged this.

Thanks again @zhfeng.

zhfeng force-pushed the issue_1918 branch from e0b926e to 730c014 Compare February 19, 2021 05:56

jamesnetherton approved these changes Feb 22, 2021

View reviewed changes

ppalaga approved these changes Feb 22, 2021

View reviewed changes

oscerd approved these changes Feb 22, 2021

View reviewed changes

aldettinger reviewed Feb 22, 2021

View reviewed changes

aldettinger approved these changes Feb 22, 2021

View reviewed changes

zhfeng force-pushed the issue_1918 branch from 730c014 to 7798bfd Compare February 22, 2021 12:53

zhfeng force-pushed the issue_1918 branch from 7798bfd to cbf68d7 Compare February 22, 2021 12:56

ppalaga requested changes Feb 22, 2021

View reviewed changes

zhfeng mentioned this pull request Feb 23, 2021

Jdbc-h2 throws com.oracle.svm.hosted.substitute.DeletedElementException during native image building quarkusio/quarkus#15267

Closed

zhfeng force-pushed the issue_1918 branch from cbf68d7 to bef3b39 Compare February 23, 2021 13:17

Fix apache#1918 to add a integration test with camel-jdbc and camel-jms

9f88d16

zhfeng force-pushed the issue_1918 branch from d71f6c7 to 9f88d16 Compare February 23, 2021 15:36

ppalaga approved these changes Feb 23, 2021

View reviewed changes

jamesnetherton closed this Feb 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1918 to add a integration test with camel-jdbc and camel-jms #2272

Fix #1918 to add a integration test with camel-jdbc and camel-jms #2272

zhfeng commented Feb 19, 2021

jamesnetherton left a comment

jamesnetherton Feb 22, 2021

zhfeng Feb 22, 2021

aldettinger Feb 22, 2021

zhfeng Feb 22, 2021

aldettinger Feb 22, 2021

zhfeng Feb 22, 2021

ppalaga Feb 22, 2021

zhfeng Feb 22, 2021

ppalaga Feb 23, 2021

zhfeng Feb 23, 2021

ppalaga Feb 23, 2021

zhfeng Feb 23, 2021

ppalaga Feb 23, 2021

zhfeng Feb 23, 2021

aldettinger left a comment

zhfeng commented Feb 22, 2021

ppalaga Feb 22, 2021

zhfeng commented Feb 23, 2021

zhfeng commented Feb 23, 2021

ppalaga left a comment

jamesnetherton commented Feb 24, 2021


		container.start();

		String brokerUrlTcp = String.format("tcp://127.0.0.1:%d/", container.getMappedPort(ACTIVEMQ_PORT));

Fix #1918 to add a integration test with camel-jdbc and camel-jms #2272

Fix #1918 to add a integration test with camel-jdbc and camel-jms #2272

Conversation

zhfeng commented Feb 19, 2021

jamesnetherton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldettinger left a comment

Choose a reason for hiding this comment

zhfeng commented Feb 22, 2021

Choose a reason for hiding this comment

zhfeng commented Feb 23, 2021

zhfeng commented Feb 23, 2021

ppalaga left a comment

Choose a reason for hiding this comment

jamesnetherton commented Feb 24, 2021