CAMEL-21216: Apache Camel LRA does not work with Oracle MicroTX LRA coordinator

[DFiedler]

Enable Oracle MicroTX lra-coordinator compatibility (https://issues.apache.org/jira/browse/CAMEL-21216).

1. While joining an LRA Transaction, the payload sent by Apache Camel is URL encoded (fix in: LRAUrlBuilder.java)
2. The Query parameter sent by Oracle LRA coordinator are url encoded, but will not be decoded by Apache Camal LRA (see also: CAMEL-21197) (workaround in: LRASagaRoutes.java)

The changes are backwards compatible to Narayana lra-coordinator.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[zhfeng]

It seems that when seding the LRA Join request, there is a wrong context-text header, maybe it need to change to application/x-www-form-urlencoded since the payload is encodeded. See

camel/components/camel-lra/src/main/java/org/apache/camel/service/lra/LRAClient.java

Lines 130 to 135 in 2e59dce

	HttpRequest request = prepareRequest(URI.create(lraEndpoint), exchange)
	.setHeader(HEADER_LINK, link.toString())
	.setHeader(Exchange.SAGA_LONG_RUNNING_ACTION, lra.toString())
	.setHeader(CONTENT_TYPE, TEXT_PLAIN_CONTENT)
	.PUT(HttpRequest.BodyPublishers.ofString(link.toString()))
	.build();

Can you share the Oracle LRA coordinator configurations? and I could use to reproduce this issue locally.

[zhfeng]

Hmm, it looks like the payload is redundant since there is a link header. So can you try to use

.PUT(HttpRequest.BodyPublishers.ofString(""))

to see if it works with Oracle LRA coordinator?

[DFiedler]

this is our current oracle lra-coordinator config ..
.. i will try your suggestion on Monday ;o)

have a nice weekend!
configmap-tcs-config.yaml.txt
statefulset-otmm-tcs.yaml.txt

[DFiedler]

Hi,

when i am changing the the code to:

.PUT(HttpRequest.BodyPublishers.ofString(""))

then i am still getting this error message from LRA-Coordinator:

error while joining LRA: 400 / error: URL is double encoded

The same error (still) occurs, if i change the header:

.setHeader(CONTENT_TYPE, "application/x-www-form-urlencoded")

best regards
Dirk

[zhfeng]

@DFiedler sorry for the late reply since there are the public holidy on Mon and Tue in China.

Well, how can I run the Oracle LRA coordinator on my local machine? is there any docker image? It would be very helpful if you can share a simple reproducer. I'd like to take a deep look.

[DFiedler]

@zhfeng we are using OpenShift as the preferred runtime, u can also use Docker: https://docs.oracle.com/en/database/oracle/transaction-manager-for-microservices/24.2/tmmdg/supported-operating-systems.html

because oracle also implements the Eclipse Microprofile LRA specification, it should work out of the box instead of Narayana (i guess u are using it for lra-coordinator) ...

In our case this is the lra-coordinator base path (oracle microtx url): http://otmm-tcs.qa-servicebuilder-dev.svc.cluster.local:9000
and this the lra-coordinator context path: api/v1/lra-coordinator

[zhfeng]

Thanks @DFiedler - I can start a oracle coordinator locally and reproduce the issue.

I'd like to discuss this issue with the Narayana team to see if there is any feedback. So let's hold the PR.

[zhfeng]

Suggested change

	copy.query += key + "=" + value;
	copy.query += toNonnullString(key) + "=" + toNonnullString(value);

[zhfeng]

@DFiedler please take a look this suggestion.

[zhfeng]

Map<String, Object> queryParam = URISupport.parseQuery(exchange.getIn().getHeader(Exchange.HTTP_QUERY, String.class));

I'd like to use a different way to parse the query string from HTTP since as @davsclaus mentions that URISupport.parseQuery is used for endpoints and have various optimized code. So it is NOT intend to as general purpose here.

[zhfeng]

Hi @DFiedler

After meeting the narayana team, it looks like

• The communications between the LRA client and coordinator is not a part of the MP LRA specification
• The Link header format is private used in Narayana LRA internally
• Oracle MicroTx LRA seems following the similar way with Narayana but we can not expect it can be OOTB
• The changes to NOT encoding the query paramters in Link is OK

[DFiedler]

Hi @zhfeng
this means, within this pull request we can deliver the whole compatibility changes for Oracle MicroTX?
Sounds good .. thanks for your investigation!

[davsclaus]

@zhfeng can you help get the last bits in place so this can be merged so it works with both oracle and narayana

[zhfeng]

@davsclaus sure, I can.

@DFiedler Do you mind I open a new PR to supersede this one?

[DFiedler]

@zhfeng I want to ask, what is the next step here .. can i do anything to finalize this PR?

[zhfeng]

@DFiedler

• Please take a look at my above suggestion on LRAUrlBuilder.java
• Have a new method to replace URISupport.parseQuery to get the parmeters from HTTP and decode them
• Maybe run ./mvnw -f components/camel-lra/pom.xml process-sources to format the files and make the CI happy.