Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAVA-3109, JAVA-2980: Support binding collections of attributes in IN clause query builder #1935

Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from
Open

JAVA-3109, JAVA-2980: Support binding collections of attributes in IN clause query builder #1935

wants to merge 3 commits into from
+155 −4

Conversation

lukasz-antoniak
Copy link
Member

@tolbertam tolbertam self-requested a review September 19, 2024 14:40
tolbertam
tolbertam approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tolbertam tolbertam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Just two tiny nits with the javadocs, 👍

core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java Outdated Show resolved Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java Outdated Show resolved Hide resolved
lukasz-antoniak and others added 2 commits September 20, 2024 07:02
@lukasz-antoniak @tolbertam
Update core/src/main/java/com/datastax/oss/driver/api/core/type/codec…
71d630e 
…/TypeCodec.java

Co-authored-by: Andrew Tolbert <6889771+tolbertam@users.noreply.github.com>
@lukasz-antoniak @tolbertam
Update core/src/main/java/com/datastax/oss/driver/api/core/type/codec…
802a93a 
…/TypeCodec.java

Co-authored-by: Andrew Tolbert <6889771+tolbertam@users.noreply.github.com>
tolbertam
tolbertam approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tolbertam tolbertam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating those changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolbertam tolbertam tolbertam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-antoniak @tolbertam