Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(android): update java requirement for cordova-android@11 #798

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 12, 2022

Platforms affected

CI: Android

Motivation and Context

Paramedic which fetches and uses the latest releases of the platform is now using Cordova-Android@11.0.0, which requires Java 11.

Description

Update the GitHub Action workflow

  • Use latest version of the actions/setup-java GitHub Action plugin
  • Use Java 11
  • Use the Java Distro temurin which is the replacement of adopt

Testing

  • See Action

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member Author

erisu commented Jul 17, 2022

The failing tests are unrelated to the change.

Error: There was a conflict trying to modify attributes with in plugin cordova-plugin-paramedic.

The change of this PR's is safe to merge.

@erisu erisu merged commit 3e54877 into apache:master Jul 17, 2022
@erisu erisu deleted the ci/update-java-requirements-cordova-android-11 branch July 17, 2022 04:30
Siedlerchr added a commit to safetyinnovation/cordova-plugin-camera that referenced this pull request Aug 1, 2022
* upstream/master:
  ci(android): update java requirement for cordova-android@11 (apache#798)
  fix(ios): preserving EXIF data (apache#712)
  fix(android): update queries in plugin.xml (apache#780)
davidofwatkins added a commit to zenput/cordova-plugin-camera that referenced this pull request Oct 20, 2023
* fix(android): update queries in plugin.xml (apache#780)

Solves the issue with duplicate queries elements in AppManifest.xml

apache#779

* fix(ios): preserving EXIF data (apache#712)

* ci(android): update java requirement for cordova-android@11 (apache#798)

* dep(npm): bump package-lock v2 w/ rebuild (apache#800)

* docs(README): Document ANDROIDX_CORE_VERSION variable (apache#808)

* fix(browser): use navigator.mediaDevices.getUserMedia (apache#810)

* ci: sync workflow with paramedic (apache#804)

* fix(android): set applicationId (apache#827)

Co-authored-by: Alexandre Alves <aalves@seamlink.com>

* chore(android): Cleanup obsolete BuildConfig comments (apache#831)

* ci(android): Drop API 22 & 31. Added API 24 & 33 (apache#835)

Co-authored-by: エリス <erisu@users.noreply.github.com>

* chore: bump plugin version 7.0.0-dev (apache#845)

* dep(dev)!: bump @cordova/eslint-config@5.0.0 (apache#846)

* dep(dev)!: bump @cordova/eslint-config@5.0.0
* chore: apply automatic lint fix

* feat(android)!: Android 13 support (apache#844)

* feat(android)!: Android 13 support
* refactor(android): simplify getPermissions logic
* feat(android)!: bump cordova-android requirement to >=12.0.0
* feat(android): update saveAlbumPermission to include Android 9 and below use case

---------

Co-authored-by: ochakov <evgeny@ochakov.com>

* chore: Update SUPPORT_QUESTION.md template (apache#849)

* fix!: remove deprecated platforms (apache#848)

* chore: remove windows/osx from plugin.xml (apache#850)

* ci(gh-action): sync with paramedic configs (apache#851)

* release(camera-v7.0.0): updated version and RELEASENOTES.md

* chore: bump version 7.0.1-dev

---------

Co-authored-by: Marcus Abrahamsson <marcus.abrahamsson13@gmail.com>
Co-authored-by: Scott Murphy <scott@alwaysvip.com>
Co-authored-by: エリス <erisu@users.noreply.github.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: seamlink-aalves <49952868+seamlink-aalves@users.noreply.github.com>
Co-authored-by: Alexandre Alves <aalves@seamlink.com>
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
Co-authored-by: ochakov <evgeny@ochakov.com>
Co-authored-by: Erisu <erisu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant