Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: improve GroupsAccumulator docs #12501

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 17, 2024

Which issue does this PR close?

Related to #6906

Rationale for this change

While working on #6906 with rationale and a potential design to improve the performance I made some diagrams to explain the context which I think would improve DataFusion

What changes are included in this PR?

  1. improve GroupsAccumulator docs (with diagram!)

Screenshot 2024-09-17 at 8 57 03 AM

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Sep 17, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 17, 2024
@alamb alamb added the documentation Improvements or additions to documentation label Sep 17, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit 3fc99de into apache:main Sep 17, 2024
25 checks passed
@alamb alamb deleted the alamb/doc_groups_accumulator branch September 17, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants