Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/apache/dubbo/issues/12615 #12676

Closed
wants to merge 1 commit into from
Closed

https://github.com/apache/dubbo/issues/12615 #12676

wants to merge 1 commit into from

Conversation

tohidemyname
Copy link

Fix the inconsistent thrown exceptions.

What is the purpose of the change

J2oVisitor throws inconsistent exceptions.

Brief changelog

Thrown IllegalStateExceptions are revised to ParseExceptions

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Fix the inconsistent thrown exceptions.
@AlbumenJ
Copy link
Member

Please fix on 3.2 branch.

@tohidemyname tohidemyname closed this by deleting the head repository Jul 13, 2023
@tohidemyname
Copy link
Author

I just checked out the source files of 3.2 but failed to find J2oVisitor.java.

This bug was found and fixed on the master branch. It may not exist in 3.2?

@CrazyHZM
Copy link
Member

CrazyHZM commented Jan 3, 2024

@tohidemyname
Yes, this issue doesn't exist in version 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants