Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): fix align error caused by float precision #18962

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Aug 5, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix align computed error caused by float precision.

Fixed issues

resolves #18954

Details

Before: What was the problem?

variable radian, not equal to Math.PI / 2 ,but -radian + Math.Pi * 2 is equal to Math.PI * 1.5, so this is a precision issue.

Before

image

After: How does it behave after the fixing?

Using a function to check theres number not around equal.

After

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 5, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18962@8734ed1

@plainheart plainheart added this to the 5.5.0 milestone Aug 6, 2023
@Ovilia Ovilia merged commit 5b448f6 into apache:master Aug 30, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Aug 30, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart removed this from the 5.5.0 milestone Jan 15, 2024
@Ovilia Ovilia mentioned this pull request Jan 25, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] sunburst series-sunburst.label. align location error
3 participants