Fix: esm issue #19593
Merged
Fix: esm issue #19593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r dist/** for file extension not specified usage (3) add dist/echarts.esm.mjs for case that not able to recognize as esm after dist/package.json with `{"type": "commonjs"}` added.
|
Thanks for your contribution! The pull request is marked to be To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
Ovilia
approved these changes
Feb 4, 2024
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19593@6cefe27 |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Previous issue #19513
This PR fixes:
dist/echarts.esm.mjs(after build). Originally there is onlydist/echarts.esm.js, which is a ESM file. Sincedist/package.jsonwith{"type": "commonjs"}is added, webpack5 can not recognize it as ESM by default. This is a breaking change. So adddist/echarts.esm.mjsfor the uses that get that trouble.