Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): fix bar bandWidth with inversed time axis #20246

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Aug 12, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix bar series bandWidth with axis typed with 'time' and inverse: true.

Fixed issues

#20068

Details

Before: What was the problem?

Wrong bandWidth:

image

After: How does it behave after the fixing?

Correct bandWidth:

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Aug 12, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.5.2 milestone Aug 12, 2024
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20246@3bd3c7c

@plainheart plainheart changed the title fix(time): bar bandWidth with inversed time axis #20068 fix(time): fix bar bandWidth with inversed time axis Aug 12, 2024
@plainheart plainheart linked an issue Aug 12, 2024 that may be closed by this pull request
@plainheart plainheart merged commit 7955a46 into master Aug 12, 2024
2 checks passed
Copy link

echarts-bot bot commented Aug 12, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the time-inverse branch August 12, 2024 11:49
@plainheart plainheart changed the title fix(time): fix bar bandWidth with inversed time axis fix(axis): fix bar bandWidth with inversed time axis Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Bar chart breaks when y-axis is time and inverse is true
2 participants