-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLINK-36332 Add option to select the Fabric8 httpclient implemention #881
base: main
Are you sure you want to change the base?
Conversation
Default to okhttp for consistency with the previous model.
<dependency> | ||
<groupId>com.squareup.okhttp3</groupId> | ||
<artifactId>okhttp</artifactId> | ||
<version>${okhttp.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default kubernetes-httpclient-okhttp
pulls in OkHttp 3.X which is reported to have problems with Kubernetes IPV6 stacks e.g. https://issues.apache.org/jira/browse/FLINK-31928
@@ -110,6 +110,7 @@ under the License. | |||
<surefire.module.config/> | |||
|
|||
<derby.version>10.15.2.0</derby.version> | |||
<jetbrains.annotations.version>24.1.0</jetbrains.annotations.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required by KubernetesAutoScalerStateStore
Lines 205 to 212 in 968a578
@NotNull | |
@Override | |
public ConfigChanges getConfigChanges(KubernetesJobAutoScalerContext jobContext) { | |
return configMapStore | |
.getSerializedState(jobContext, CONFIG_OVERRIDES_KEY) | |
.map(KubernetesAutoScalerStateStore::deserializeConfigOverrides) | |
.orElse(new ConfigChanges()); | |
} |
though looking again that looks like a bug and it should use @nonnull
instead.
What is the purpose of the change
Enable the building of the operator using alternative Fabric8 http clients.
Brief change log
Enable the building of the operator using alternative Fabric8 http clients.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
The build should still work even when run with
-Dfabric8.httpclinent.impl=vertx
orjdk
orjetty
for that matter 😁Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation