[bug] fix reading with to_arrow_batch_reader and limit
#1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
force-pushed
the
kevinjqliu/yield-bug
branch
from
b1940e3
to
18fb8e6
Compare
Fokko
approved these changes
Aug 12, 2024
sungwy
approved these changes
Aug 12, 2024
|
LGTM. Thank you for fixing this bug @kevinjqliu ! |
sungwy
pushed a commit
that referenced
this pull request
Aug 13, 2024
* fix project_batches with limit * add test * lint + readability
sungwy
added a commit
to sungwy/iceberg-python
that referenced
this pull request
Aug 14, 2024
Fokko
pushed a commit
that referenced
this pull request
Aug 20, 2024
* refactoring * refactor more * docstring * #1042 * adopt review feedback * thanks Kevin! Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040