Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Install Issues with docutils = 0.21.post1 and exclude 3.12 from supported python dependencies #1067

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Aug 15, 2024

Currently, when users try to install using poetry with python3.12, they run into the following error:

  - Installing numpy (1.24.4): Failed

  ChefBuildError

  Backend 'setuptools.build_meta:__legacy__' is not available.

  Cannot import 'setuptools.build_meta'

  at venv/lib/python3.12/site-packages/poetry/installation/chef.py:164 in _prepare
      160│
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│
      163│             if error is not None:
    → 164│                 raise error from None
      165│
      166│             return path
      167│
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.4) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "numpy (==1.24.4)"'.

The proposed solution excludes 3.12 from the supported versions in the dependencies, so that poetry will attempt to find a compatible python version to install the dependencies instead.

The currently activated Python version 3.12.4 is not supported by the project (>=3.8, <3.12, !=3.9.7).
Trying to find and use a compatible version. 
Using python3.8 (3.8.19)

@sungwy sungwy marked this pull request as ready for review August 15, 2024 22:32
@kevinjqliu
Copy link
Contributor

The proposed solution excludes 3.12 from the supported versions in the dependencies

Do we not support 3.12 at all?

classifiers = [
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
]

@Fokko
Copy link
Contributor

Fokko commented Aug 16, 2024

@kevinjqliu Officially not since we don't run it in CI yet. In CI we run all the integration tests against the different platform, and I believe Ray was not on 3.12 yet. cc @MehulBatra

@sungwy sungwy merged commit 2cc89f9 into apache:main Aug 16, 2024
7 checks passed
@sungwy sungwy deleted the bf-install-issues branch August 16, 2024 13:09
@sungwy
Copy link
Collaborator Author

sungwy commented Aug 16, 2024

@Fokko @kevinjqliu @ndrluis

Do you folks think this needs to be pulled into 0.7.1 with a new RC?

We do have a section about not supporting 3.12 yet in Verify a Release section, but I think it's more straight forward to remove it from the dependencies as we did in this PR.

@ndrluis
Copy link
Collaborator

ndrluis commented Aug 16, 2024

I think we don't need this in the new RC. I believe it would make sense to push this to the RC only if we stopped supporting version 3.12 in this specific release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants