Revert "Cache Manifest files"

[kevinjqliu]

Reverts #787
Closes #1162

Integration tests (make test-integration) fail when this commit, but only for M1 Mac.

• See [bug?] cannot run integration test  #1162. Another user reported issue when running with M1 Mac.
• kevinjqliu/iceberg-python/#5 ran integration test against none M1 macs (Github Action macos-12, macos-13) and test succeeded.

Integration tests pass 100% with the commit reverted

Error log:

• https://gist.github.com/kevinjqliu/c8310b6253beab52cce93391df03bfe4
• https://gist.github.com/kevinjqliu/a0e8e2199bd8064757eb2b40409e0794

[sungwy]

Hi @kevinjqliu thanks for putting this together. Would you mind sharing the verbose exception trace for this issue? Conceptually, I don't think this should result in an error because the ManifestFile should have been cached as Records in memory.

I'd like to understand this issue better to see if we can find a different solution than reverting this great feature

[kevinjqliu]

@sungwy thanks for following up on this. I added more details in the PR description.

My suspicion is that this is due to the generators in read_manifest_list and fetch_manifest_entry, but its is just a hunch.

[sungwy]

My suspicion is that this is due to the generators in read_manifest_list and fetch_manifest_entry, but its is just a hunch.

Hey thanks for the link @kevinjqliu - I think that gist only has the short test summary information, not the long exception traceback

[kevinjqliu]

@sungwy here you go
https://gist.github.com/kevinjqliu/a0e8e2199bd8064757eb2b40409e0794

[kevinjqliu]

Closing in favor of #1185