Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set table properties with dictionary #503

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Mar 7, 2024

Resolves #502

This PR modifies the Transactions set_properties API to allow passing table properties either as dictionary or as kwargs
For example,

with table.transaction() as transaction: 
    transaction.set_properties(abc="def")
    transaction.set_properties({"abc": "def"}) 

set_properties only allows table properties to be passed in either via dictionary or kwarg, not both. This removes complexity when both are set.

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kevinjqliu !

@HonahX HonahX merged commit ad40573 into apache:main Mar 8, 2024
7 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/pass-properties-as-dict branch March 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] easier API to set table properties
2 participants