Core: Allow customizing OAuth scope #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
rest-catalog-customize-scope
branch
2 times, most recently
from
3c9963e
to
64c1da5
Compare
rdblue
reviewed
Jan 18, 2023
rdblue
reviewed
Jan 18, 2023
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
rest-catalog-customize-scope
branch
2 times, most recently
from
0e925ed
to
05f6763
Compare
nastra
force-pushed
the
rest-catalog-customize-scope
branch
from
05f6763
to
4b5ee1a
Compare
rdblue
reviewed
Jan 23, 2023
| response.token(), | ||
| response.issuedTokenType(), | ||
| credential, | ||
| parent.scope()); |
There was a problem hiding this comment.
When this is called in fromTokenExchange, the scope passed there is not passed in here. I think that this method needs to have a scope argument. Then the fromTokenResponse above can pass parent.scope() and fromTokenExchange can pass the scope it was passed.
There was a problem hiding this comment.
I've simplified this to actually and removed the scope parameter from fromTokenExchange/fromCredential as I think we need to take the scope from the parent in those cases
nastra
force-pushed
the
rest-catalog-customize-scope
branch
from
4b5ee1a
to
909d3bb
Compare
rdblue
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6169 we're planning to re-use
AuthSessionbut we need the ability to use ascope, which is different from the defaultOAuth2Properties.CATALOG_SCOPE