Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: superstep not take effect #237

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

JackyYangPassion
Copy link
Contributor

fix #236

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #237 (9ddfe24) into master (cc5a7e7) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     85.83%   85.89%   +0.05%     
- Complexity     3232     3235       +3     
============================================
  Files           344      344              
  Lines         12072    12108      +36     
  Branches       1087     1090       +3     
============================================
+ Hits          10362    10400      +38     
- Misses         1185     1187       +2     
+ Partials        525      521       -4     
Impacted Files Coverage Δ
...graph/computer/core/sender/MessageSendBuffers.java 86.36% <33.33%> (-8.38%) ⬇️
...graph/computer/core/sender/MessageSendManager.java 78.40% <100.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin changed the title fix superstep not effect fix: superstep not take effect May 8, 2023
@coderzc
Copy link
Member

coderzc commented Jun 1, 2023

CI failed:

Error: testRunAlgorithm(org.apache.hugegraph.computer.algorithm.community.lpa.LpaTest) Time elapsed: 9.086 s <<< ERROR!
org.apache.hugegraph.exception.ServerException: Null key for a Map not allowed in JSON (use a converting NullKeySerializer?) (through reference chain: java.util.ArrayList[0]->java.util.HashMap["null"])
at org.apache.hugegraph.computer.algorithm.community.lpa.LpaTest.testRunAlgorithm(LpaTest.java:40)
Caused by: org.apache.hugegraph.exception.ServerException$ServerCause: [org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException]

@coderzc
Copy link
Member

coderzc commented Jun 1, 2023

@JackyYangPassion You can refer to TriangleCountTest to verify the algorithm results

@JackyYangPassion
Copy link
Contributor Author

@JackyYangPassion You can refer to TriangleCountTest to verify the algorithm results

It is being tested and will help review after CI passes

@JackyYangPassion
Copy link
Contributor Author

Unit test for #236
lpa expect result is 4 community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] LPA result not as expected
4 participants