Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): update license for 1.2.0 #299

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

diaohancai
Copy link
Contributor

Purpose of the PR

Main Changes

Add or remove license compared to release1.0.0.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin
Copy link
Member

imbajin commented Dec 18, 2023

also comment this line to avoid generate binary pkg

cp -v ../../target/apache-${REPO}-incubating-"${RELEASE_VERSION}".tar.gz \

@diaohancai
Copy link
Contributor Author

also comment this line to avoid generate binary pkg

cp -v ../../target/apache-${REPO}-incubating-"${RELEASE_VERSION}".tar.gz \

Done.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (e0b484a) 85.03% compared to head (65472d4) 84.96%.
Report is 4 commits behind head on master.

Files Patch % Lines
...apache/hugegraph/computer/core/bsp/EtcdClient.java 52.38% 6 Missing and 4 partials ⚠️
.../hugegraph/computer/core/worker/WorkerService.java 85.93% 8 Missing and 1 partial ⚠️
.../hugegraph/computer/core/master/MasterService.java 50.00% 4 Missing and 3 partials ⚠️
...raph/computer/k8s/operator/OperatorEntrypoint.java 81.81% 2 Missing ⚠️
...h/computer/core/network/session/ClientSession.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
- Coverage     85.03%   84.96%   -0.07%     
- Complexity     3296     3301       +5     
============================================
  Files           349      349              
  Lines         12485    12500      +15     
  Branches       1130     1132       +2     
============================================
+ Hits          10616    10621       +5     
- Misses         1329     1339      +10     
  Partials        540      540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin previously approved these changes Dec 19, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Also check NOTICE file~

@diaohancai
Copy link
Contributor Author

diaohancai commented Dec 19, 2023

Note: Also check NOTICE file~

Did not found notice:

+bcprov-jdk18on-1.74.jar     # https://github.com/bcgit/bc-java
+javax.inject-2.5.0-b32.jar  # https://github.com/javaee/hk2
+okio-jvm-3.0.0.jar          # https://github.com/square/okio
+okio-jvm-3.2.0.jar          # https://github.com/square/okio
+simple-xml-safe-2.7.1.jar   # https://github.com/carrotsearch/simplexml-safe

@imbajin imbajin merged commit 0500fec into apache:master Dec 19, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants