Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dist): replace G1 config & handle other gc options #2664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MingzhenHan
Copy link

Subtask of #2575

If the user does not specify the GC method, g1 will be used by default.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 14, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: no need to choose g1 for gc (so we could enhance the logic)

@imbajin imbajin changed the title chore(dist): set G1 as the default gc chore(dist): replace G1 config & handle other gc options Sep 14, 2024
@imbajin imbajin added this to the 1.5.0 milestone Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.71%. Comparing base (c88963c) to head (b4ce800).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2664      +/-   ##
============================================
- Coverage     47.65%   43.71%   -3.95%     
+ Complexity      820      623     -197     
============================================
  Files           718      729      +11     
  Lines         58469    59536    +1067     
  Branches       7496     7663     +167     
============================================
- Hits          27866    26026    -1840     
- Misses        27815    30786    +2971     
+ Partials       2788     2724      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants