[DROOLS-6627] Verify Scorecard reasoncode when result is null #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-core/src/main/java/org/kie/pmml/compiler/executor/PMMLCompilerImpl.java
# Conflicts: # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/builders/KiePMMLModelCodegenUtilsTest.java # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/codegenfactories/KiePMMLModelFactoryUtilsTest.java
# Conflicts: # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/builders/KiePMMLModelCodegenUtilsTest.java # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/codegenfactories/KiePMMLModelFactoryUtilsTest.java # kie-pmml-trusty/kie-pmml-models/kie-pmml-models-drools/kie-pmml-models-drools-common/src/main/java/org/kie/pmml/models/drools/commons/model/KiePMMLDroolsModel.java
# Conflicts: # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/builders/KiePMMLModelCodegenUtilsTest.java
# Conflicts: # kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-commons/src/test/java/org/kie/pmml/compiler/commons/builders/KiePMMLModelCodegenUtilsTest.java
jiripetrlik
approved these changes
Oct 5, 2021
danielezonca
reviewed
Oct 5, 2021
| KiePMMLSessionUtils.Builder builder = KiePMMLSessionUtils.builder((KieBase) knowledgeBase, name, packageName, | ||
| toReturn) | ||
| .withObjectsInSession(requestData, fieldTypeMap) | ||
| .withOutputFieldsMap(outputFieldsMap); | ||
| .withOutputFieldsMap(holder); | ||
| outputFieldsMap = holder; |
There was a problem hiding this comment.
Is this necessary? I don't usually like a method that changes the instance of a field. Isn't possible to do
outpitFieldsMap.putAll(output)
?
Or do a clear() if necessary
There was a problem hiding this comment.
@danielezonca
done
| reasonCodeAlgorithm, | ||
| useReasonCodes, | ||
| baselineScore).orElse(null); | ||
| outputFieldsMap = holder; |
There was a problem hiding this comment.
@danielezonca
done
|
Kudos, SonarCloud Quality Gate passed!
|
danielezonca
approved these changes
Oct 6, 2021
gitgabrio
added a commit
to gitgabrio/drools
that referenced
this pull request
Oct 6, 2021
…#3875) * [DROOLS-6625] Managing missing "required" input data * [DROOLS-6625] Managing best-effort conversion of input data * [DROOLS-6625] Managing invalid values - TODO: integration tests * [DROOLS-6625] Managing invalid values * [DROOLS-6625] Managing missing values * [DROOLS-6625] Validate input data * [DROOLS-6635] Move testing sources in specific files * [DROOLS-6625] Fix merge with base branch * [DROOLS-6625] Fix as per PR suggestion * [DROOLS-6635] Fix merge * [DROOLS-6627] Verify Scorecard reasoncode when result is null * [DROOLS-6635] Fix merge with 7.x * [DROOLS-6627] Fix merge * [DROOLS-6627] Fixed as per PR request
danielezonca
pushed a commit
that referenced
this pull request
Oct 7, 2021
…#3883) * [DROOLS-6625] Managing missing "required" input data * [DROOLS-6625] Managing best-effort conversion of input data * [DROOLS-6625] Managing invalid values - TODO: integration tests * [DROOLS-6625] Managing invalid values * [DROOLS-6625] Managing missing values * [DROOLS-6625] Validate input data * [DROOLS-6635] Move testing sources in specific files * [DROOLS-6625] Fix merge with base branch * [DROOLS-6625] Fix as per PR suggestion * [DROOLS-6635] Fix merge * [DROOLS-6627] Verify Scorecard reasoncode when result is null * [DROOLS-6635] Fix merge with 7.x * [DROOLS-6627] Fix merge * [DROOLS-6627] Fixed as per PR request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielezonca @kostola @jiripetrlik
See https://issues.redhat.com/browse/DROOLS-6627
Please note there is an underlying issue not completely fixed, i.e. the "status" of "KiePMMLModel" that it is preserved between multiple invocation.
The overall fix will require a global refactor, and will be addressed by https://issues.redhat.com/browse/DROOLS-6641
This PR must be merged after https://github.com/kiegroup/drools/pull/3868