Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1462] Refactoring springboot integration tests configuration to avoid usage of extensions flag #3656

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-issues#1462

This PR refactor the spring boot integration tests poms to avoid usage of extensions flag, redefining the lifecicle in the poms themselves.
To exactly recreate the same steps, some hack has been used

  1. multiple declaration of same plugins (maven-compile-plugin and kogito-maven-plugin)
  2. mapping of plugin to "wrong" phases (process-resources)

The execution order can be viewed/compared using

mvn fr.jcgay.maven.plugins:buildplan-maven-plugin:list

Thanks to @elguardian for pom modification suggestion

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

…configuration to avoid usage of extensions flag
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. merge when green

@gitgabrio gitgabrio merged commit 5d04d8b into apache:main Sep 3, 2024
6 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1462 branch September 3, 2024 13:53
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Sep 5, 2024
…configuration to avoid usage of extensions flag (apache#3656)

* [incubator-kie-issues#1462] Refactoring springboot integration tests configuration to avoid usage of extensions flag

* [incubator-kie-issues#1462] Avoid duplicated declarationof same plugin

---------

Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt kogito-runtimes/springboot integration tests to avoid usage of extensions flag for kogito-maven-plugin
4 participants