Dispose KieSession after rules execution when using ruleFlowGroup

[martinweiler]

Closes apache/incubator-kie-issues#1491

[gitgabrio]

Thx @martinweiler

[mariofusco]

I'm not understanding why the instanceof is performed against the concrete class instead of simply checking the KieSession interface here.

[martinweiler]

Thanks for the input @mariofusco

[elguardian]

This is ok for me. We don't use the old engine anymore in prod.

[kie-ci3]

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3678 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3678/2/display/redirect

Test results:

• PASSED: 3319
• FAILED: 5

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2

expected: 2
but was: 1

org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances

1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval

org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances

1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval

org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTest

Expecting value to be false but was true

org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances

1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval

[martinweiler]

The test failures are unrelated and are currently showing up on other PRs as well.