Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#119: VS Code Extensions should keep their Editors in sync even when files change externally #2358

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

kie-issues#119: VS Code Extensions should keep their Editors in sync even when files change externally #2358

wants to merge 14 commits into from

Conversation

Josephblt
Copy link
Member

@Josephblt Josephblt commented May 23, 2024 •
edited by yesamer
Loading

Closes apache/incubator-kie-issues#119

Done:

  • Created file watcher to track changes in file sources.

Next steps:

  • Identify source sync status.
  • Create sync control dialog.
  • Sync accordingly.

@yesamer yesamer changed the title incubator-kie-issues#119:VS Code Extensions should keep their Editors in sync even when files change externally incubator-kie-issues#119: VS Code Extensions should keep their Editors in sync even when files change externally May 23, 2024
@Josephblt Josephblt marked this pull request as draft May 23, 2024 11:48
@Josephblt Josephblt added the pr: wip PR is still under development label May 23, 2024
@tiagobento tiagobento changed the title incubator-kie-issues#119: VS Code Extensions should keep their Editors in sync even when files change externally kie-issues#119: VS Code Extensions should keep their Editors in sync even when files change externally May 24, 2024
@Josephblt
VS Code Extension finalized. BPMN and DMN validation fully implemented.
5df1846
@Josephblt
Adds the Extended Services VS Code Extension to:
e9b8291 
Kogito Bundle
KIE Business Automation Bundle
@Josephblt
Added helper hints recommending Extended-Services.
bdecf77
@Josephblt
Fixed two bugs:
292d52b 
Custom editor only detect changes after saving 2 times.
Changes from outside sources were not detected
@Josephblt
Refactory
e583494 
Changed folders, function and class names
Changed file structure
Applied functional style where possible
Variable Grooming
Solved nesting issues
@Josephblt
Removing Unnecessary Tests, more code grooming.
9f6e410
@Josephblt
Formatting fix.
92a2b72
@Josephblt
Fix for Windows platforms.
1e5081f
@Josephblt
Fixed output directory in launch file.
8d19235 
Removed pretier configuration from settings.
@Josephblt
Fixed validation issue. The connection is not automatically closed if…
9616058 
… a error happens during the validation.
@Josephblt
Fixed problems with the enableAutorun configuration.
b397c64 
Changed description for connect/disconnect commands.
@Josephblt
Fix to propperly finish local service.
52c8282
@Josephblt
Fix for stale content from textDocuments.
ca00754
@Josephblt
E2E Tests - Unfinished
73a7f27
@tiagobento
Copy link
Contributor

I merged #2165, can you please update this PR?

@Josephblt
Copy link
Member Author

Hello @tiagobento. Yes, sure thing. I still need to make some changes to this, but I'll update it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederign ederign Awaiting requested review from ederign

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@paulovmr paulovmr Awaiting requested review from paulovmr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:core pr: wip PR is still under development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS Code Extensions should keep their Editors in sync even when files change externally
3 participants
@Josephblt @tiagobento @yesamer