optimize: compatible with lower versions of SPI #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compatible_spi # Conflicts: # compatible/pom.xml
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6315 +/- ##
============================================
+ Coverage 51.93% 52.39% +0.45%
- Complexity 5185 5216 +31
============================================
Files 921 920 -1
Lines 32166 31913 -253
Branches 3874 3805 -69
============================================
+ Hits 16706 16721 +15
+ Misses 13822 13546 -276
- Partials 1638 1646 +8
|
xingfudeshi
changed the title
xingfudeshi
changed the title
slievrly
reviewed
Feb 5, 2024
slievrly
reviewed
Feb 5, 2024
common/src/main/java/org/apache/seata/common/loader/EnhancedServiceLoader.java
Show resolved
Hide resolved
slievrly
reviewed
Feb 5, 2024
compatible/src/main/java/io/seata/core/compressor/Compressor.java
Outdated
Show resolved
Hide resolved
xingfudeshi
changed the title
xingfudeshi
changed the title
slievrly
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I suggest changing the SPI loading priority here.
- Load the Apache Seata SPI first. Because Apache Seata is the final state of the future.
- If the Apache seata SPI cannot be found, output a warn log and try to load the io.seata SPI.
- If the io.seata SPI also fails to be loaded, handle the exception according to the logic in the original SPI.
Ok |
|
Done. @slievrly |
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6307
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews