Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add fastjson2 serializer support #6904

Open
wants to merge 9 commits into
base: 2.x
Choose a base branch
from

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Oct 8, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

支持 fastJson2序列化RPC消息
Support fastJson2 serialization of RPC messages

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Configure the serialization method to fastjson2

Ⅴ. Special notes for reviews

关于是否统一序列化类型为FastJson(即去除fastjson1,统一采用fastjson2),这个很大程度依赖与fastjson2的兼容性,undolog的对象结构复杂,大概率做不到100%兼容,故这里应该需要区分fastjson1和fastjson2,而如果RPC统一为fastjson,两边的配置叫法就不是很统一

Whether to unify the serialization type to FastJson (i.e., remove fastjson1 and unify to fastjson2) depends largely on the compatibility with fastjson2. The object structure of undolog is complex and it is highly unlikely to be 100% compatible. Therefore, it is necessary to distinguish between fastjson1 and fastjson2. If RPC is unified as fastjson, the configuration names on both sides will not be very unified.

@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/rm-datasource rm-datasource module module/serializer serializer module labels Oct 9, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 9, 2024
/**
* The fastjson2.
* <p>
* Math.pow(2, 5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Math.pow(2, 5)
* Math.pow(2, 6)

import org.apache.seata.core.serializer.SerializerSecurityRegistry;

/**
* @Author GoodBoyCoder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove author

import org.apache.seata.core.serializer.Serializer;

/**
* @Author GoodBoyCoder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module module/serializer serializer module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants