Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11166 -- Remove asserts for flaky tests in VersionGarbageCollecto… #1759

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

OAK-11166 -- Remove asserts for flaky tests in VersionGarbageCollecto… #1759

wants to merge 1 commit into from
+0 −20

Conversation

ionutzpi
Copy link
Contributor

@ionutzpi ionutzpi commented Oct 4, 2024

Remove asserts for flaky tests in VersionGarbageCollectorIT and BranchCommitGCTest

reschke
reschke approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling tests sounds good to me.

@Joscorbe
Copy link
Member

Joscorbe commented Oct 4, 2024

I have approved the run in the pipeline to see the result of tests.

@stefan-egli
Copy link
Contributor

I probably missed this : what was the fix done that allows this?

@ionutzpi
Copy link
Contributor Author

ionutzpi commented Oct 7, 2024 •
edited
Loading

@stefan-egli adding code to drop tables for RDB H2 solved some issues previous generated.

@stefan-egli
Copy link
Contributor

@ionutzpi the flakyness wasn't specifically on RDB though, we don't have it documented consistently but for example OAK-10843 and OAK-10853, which introduced some of those assumeTrue, were on MongoDb. I don't think we can re-enable them based on the RDB fix alone.

@reschke reschke self-requested a review October 8, 2024 11:33
reschke
reschke reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @stefan-egli said - this only make sense if the underlying problems were fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reschke reschke reschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ionutzpi @Joscorbe @stefan-egli @reschke