Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #129

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions jackrabbit-core/src/test/java/org/apache/jackrabbit/core/OracleRepositoryTest.java
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.io.File;
import java.io.InputStream;
import java.nio.file.Files;
import java.util.Properties;

import javax.jcr.Session;
Expand Down Expand Up @@ -46,9 +47,7 @@ protected void setUp() throws Exception {
|| !sysProps.containsKey("tests.oracle.indexTablespace")) {
throw new IllegalStateException("Missing system property for test");
}
dir = File.createTempFile("jackrabbit_", null, new File("target"));
dir.delete();
dir.mkdir();
dir = Files.createTempDirectory(new File("target").toPath(), "jackrabbit_").toFile();
final InputStream in = getClass().getResourceAsStream(
"/org/apache/jackrabbit/core/repository-oracle.xml");
config = RepositoryConfig.create(in, dir.getPath());
Expand Down
5 changes: 2 additions & 3 deletions ...it-core/src/test/java/org/apache/jackrabbit/core/OracleRetrocompatibleRepositoryTest.java
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.io.File;
import java.io.InputStream;
import java.nio.file.Files;
import java.util.Properties;

import javax.jcr.Session;
Expand Down Expand Up @@ -45,9 +46,7 @@ protected void setUp() throws Exception {
|| !sysProps.containsKey("tests.oracle.tablespace")) {
throw new IllegalStateException("Missing system property for test");
}
dir = File.createTempFile("jackrabbit_", null, new File("target"));
dir.delete();
dir.mkdir();
dir = Files.createTempDirectory(new File("target").toPath(), "jackrabbit_").toFile();
final InputStream in = getClass().getResourceAsStream(
"/org/apache/jackrabbit/core/repository-oracle-compat.xml");
config = RepositoryConfig.create(in, dir.getPath());
Expand Down
5 changes: 2 additions & 3 deletions ...bit-core/src/test/java/org/apache/jackrabbit/core/persistence/PersistenceManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.apache.jackrabbit.core.persistence;

import java.io.File;
import java.nio.file.Files;
import java.util.Arrays;

import javax.jcr.PropertyType;
Expand Down Expand Up @@ -62,9 +63,7 @@ public class PersistenceManagerTest extends TestCase {
private File database;

protected void setUp() throws Exception {
directory = File.createTempFile("jackrabbit-persistence-", "-test");
directory.delete();
directory.mkdirs();
directory = Files.createTempDirectory("jackrabbit-persistence-" + "-test").toFile();

database = File.createTempFile("jackrabbit-persistence-", "-derby");
database.delete();
Expand Down
5 changes: 2 additions & 3 deletions jackrabbit-core/src/test/java/org/apache/jackrabbit/core/util/RepositoryLockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.io.File;
import java.io.IOException;
import java.nio.file.Files;

import javax.jcr.RepositoryException;

Expand All @@ -37,9 +38,7 @@ public class RepositoryLockTest extends TestCase {
* Sets up the temporary directory used for testing.
*/
protected void setUp() throws IOException {
directory = File.createTempFile("RepositoryLock", "Test");
directory.delete();
directory.mkdir();
directory = Files.createTempDirectory("RepositoryLock" + "Test").toFile();
}

/**
Expand Down