Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContextBuilder bug when using credentials supplier with azureblob #207

Merged

Conversation

maxjaspersmiley
Copy link

Azure cloud providers specifically use an identity as part of their endpoint.

When attempting to use a ContextBuilder with the (new-ish?) credentialsSupplier option, we were seeing errors building an endpoint due to string interpolation failures, since the Azure module was not expecting a Supplier (rather, a specific identity and credential)

This is not a comprehensive fix (any subsequent change to the identity will not be reflected in the endpoint going forward) but partially addresses a serious problem (unable to use ContextBuilder's credentialsSupplier for Azure providers)

I plan on a more thorough change that will allow on-the-fly changes to an Azure provider's identity/credential, but this is more difficult. I believe I'll need to find every place where the endpoint is referenced and handle the case where a credentialsSupplier is being used (IOW, every place where the endpoint must be generated on the fly).

Any pointers or feedback about the above is appreciated!

@gaul gaul merged commit d62322c into apache:master Aug 6, 2024
1 check passed
@gaul
Copy link
Member

gaul commented Aug 6, 2024

Thank you for your contribution @maxjaspersmiley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants