MINOR: Fix a race and add JMH bench for HdrHistogram #17221
+178
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
An encore of #17184, this addresses the race described #16949 (comment) and adds a JMH benchmark comparing
HdrHistogram
with Yammer's histogram. It also addresses some nits from that previous PR and rebases on top of the #17011 changes.A sample result from a local run on my development machine:
Testing
In addition to the JMH benchmark, and unlike the original PR, #17184, this also includes a fairly reliable test for the race that's being fixed.
Committer Checklist (excluded from commit message)