KAFKA-16908: Refactor QuorumConfig with AbstractConfig
#17231
+26
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Sep 19, 2024
| @@ -47,7 +47,7 @@ | |||
| * controller should be able to transition from standby to active without reloading all of | |||
| * the metadata. The standby is a "hot" standby, not a "cold" one. | |||
| */ | |||
| public class QuorumConfig { | |||
| public class QuorumConfig extends AbstractConfig { | |||
There was a problem hiding this comment.
Does it need to extend AbstractConfig if it's constructor accepts a AbstractConfig already?
There was a problem hiding this comment.
Does it need to extend
AbstractConfigif it's constructor accepts aAbstractConfigalready?
Indeed, having it extend AbstractConfig is unnecessary. And I have removed it. PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Committer Checklist (excluded from commit message)