Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-381] - Refactor incremental detection #181

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Feb 17, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@jorsol jorsol force-pushed the MCOMPILER-381 branch 3 times, most recently from bb29024 to 2660e16 Compare March 3, 2023 19:32
@jorsol jorsol marked this pull request as draft March 14, 2023 12:27
@jorsol jorsol marked this pull request as ready for review October 23, 2023 15:21
@slawekjaranowski
Copy link
Member

@khmarbaise looks like you reported issue which this PR try to fix ... can you look?

@jorsol jorsol marked this pull request as draft November 10, 2023 11:15
@jorsol jorsol marked this pull request as ready for review November 12, 2023 21:00
@jorsol jorsol force-pushed the MCOMPILER-381 branch 2 times, most recently from 33680c5 to b6a3aba Compare November 26, 2023 22:00
@jorsol jorsol requested a review from olamy November 26, 2023 22:04
@jorsol jorsol marked this pull request as draft November 27, 2023 13:25
@jorsol jorsol force-pushed the MCOMPILER-381 branch 2 times, most recently from f808bc0 to 8512eca Compare November 28, 2023 11:57
@jorsol jorsol marked this pull request as ready for review November 28, 2023 12:11
@slawekjaranowski
Copy link
Member

@olamy - any more remarks on it, I would like to merge

@jorsol
Copy link
Contributor Author

jorsol commented Dec 4, 2023

Hi @olamy, is there any other feedback?

@jorsol
Copy link
Contributor Author

jorsol commented Dec 6, 2023

Well, I think this should be ready to be merged if there is no other comment.

BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

@olamy
Copy link
Member

olamy commented Dec 6, 2023

Well, I think this should be ready to be merged if there is no other comment.

BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

it's usually better to have a PR per change, especially in case of non-related changes.
But as you already hijacked this PR #186 here, it would be good to have this in the PR title and commits for history.
And obviously, update https://issues.apache.org/jira/browse/MCOMPILER-333

@jorsol
Copy link
Contributor Author

jorsol commented Dec 7, 2023

Well, I think this should be ready to be merged if there is no other comment.
BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

it's usually better to have a PR per change, especially in case of non-related changes. But as you already hijacked this PR #186 here, it would be good to have this in the PR title and commits for history. And obviously, update https://issues.apache.org/jira/browse/MCOMPILER-333

Sure, will create a new PR for that change. the fix is simpler than the one from #186.

Reverted the change here and included it on #214

@olamy
Copy link
Member

olamy commented Dec 7, 2023

@jorsol thanks for creating another PR with the other change!

@olamy
Copy link
Member

olamy commented Dec 7, 2023

mvn spotless:apply should help here ;)

Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@jorsol
Copy link
Contributor Author

jorsol commented Dec 7, 2023

mvn spotless:apply should help here ;)

Done! 😅

@olamy olamy merged commit ea74978 into apache:master Dec 8, 2023
118 checks passed
@jorsol jorsol deleted the MCOMPILER-381 branch December 8, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants