[MSHARED-1036] Analyze project classes only once #52
Conversation
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MSHARED-1036
branch
from
be58e8e
to
08a9504
Compare
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return testOnlyDependencyClasses; | ||
| return testDependencyClasses.stream() |
There was a problem hiding this comment.
By any chance do we already depend on Apache Commons Colelctions? If so, consider using SetUtils.difference which would read clearer. If not, add a comment like
// Find classes used by tests not also used by the model code
Or you could just use Set.removeAll to pull the mainDependencyClasses out and leave the test onlly classes behind. That's probably simplest.
There was a problem hiding this comment.
use Set.removeAll
| @@ -201,48 +206,26 @@ else if ( file != null && file.isDirectory() ) | |||
| return artifactClassMap; | |||
| } | |||
|
|
|||
| private Set<String> buildTestDependencyClasses( MavenProject project ) throws IOException | |||
| private Set<String> buildTestOnlyDependencyClasses( Set<String> mainDependencyClasses, | |||
There was a problem hiding this comment.
perhaps change "build" to "list" or "find" since you're not creating the objects here, which builder methods usually do
There was a problem hiding this comment.
now build new instance ... so don't remove
| @@ -201,48 +206,26 @@ else if ( file != null && file.isDirectory() ) | |||
| return artifactClassMap; | |||
| } | |||
|
|
|||
| private Set<String> buildTestDependencyClasses( MavenProject project ) throws IOException | |||
| private Set<String> buildTestOnlyDependencyClasses( Set<String> mainDependencyClasses, | |||
There was a problem hiding this comment.
I think this method can be static now
slawekjaranowski
force-pushed
the
MSHARED-1036
branch
from
08a9504
to
027e8e0
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. Also be sure having selected the correct component.
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHARED-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.