Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rewrite for clarity #9

Merged
merged 2 commits into from
Mar 22, 2020
Merged

docs: rewrite for clarity #9

merged 2 commits into from
Mar 22, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 22, 2020

khmarbaise
khmarbaise approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@khmarbaise khmarbaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier

michael-o
michael-o requested changes Mar 22, 2020
View reviewed changes
src/site/apt/index.apt.vm Outdated
if they are the only use of a dependency.
<<Warning>>: Because analysis is done on the bytecode rather than the source,
some cases are not detected including constants, annotations with source-only retention,
and links in javadoc. This can lead to incorrect results when these are the only uses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit 34e3306 into master Mar 22, 2020
@elharo elharo deleted the elharo-patch-1 branch March 22, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@michael-o michael-o michael-o approved these changes

Assignees

@hboutemy hboutemy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @khmarbaise @michael-o @hboutemy