-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEP-779 show class names used in undeclared dependencies #178
MDEP-779 show class names used in undeclared dependencies #178
Conversation
|
ea117ae
to
b99d6fd
Compare
Great; I've rebased on top of 7b8ff3d. |
We need some tests to confirm regressions in next releases. |
There is test |
This fixture works for the analyzer test; copy it over.
Invoke dependency:analyze-only in verbose mode, and ensure that the result includes the expected warnings.
import org.codehaus.plexus.util.*; | ||
|
||
String log = FileUtils.fileRead( new File( basedir, "build.log" ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use groovy script here ... and we needn't external dependencies.
look for build.log reading in another groovy scripts
String expected = "[WARNING] Used undeclared dependencies found:\n" | ||
+ "[WARNING] xml-apis:xml-apis:jar:1.0.b2:compile\n" | ||
+ "[WARNING] class org.apache.xmlcommons.Version\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we must use system native end line ...
e52a02b
to
4122b8e
Compare
This adds the class names tracked in this PR to the UI, when
-Dverbose
is set:It also includes the small changes necessary for any upgrade of
maven-dependency-analyzer
to1.12
.To allow this to be reviewed ahead of a release of
maven-dependency-analyzer
, the version is set to1.12.0-SNAPSHOT
; if approved, it'll presumably be1.12.0
. As mentioned, it ties the new output to-Dverbose
; I think this is simpler than adding a new specific property, and less disruptive than enabling it by default.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MDEP-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.