Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MENFORCER-500] New rule to enforce that Maven coordinates match given #309

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Mar 22, 2024

patterns

Optionally allows to enforce the module directory name being equal to the module's artifactId.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin force-pushed the feature/require-matching-coordinates branch from e30eb8f to 00d3a0e Compare March 22, 2024 20:09
patterns

Optionally allows to enforce the module directory name being equal to
the module's artifactId.
@kwin kwin force-pushed the feature/require-matching-coordinates branch from 00d3a0e to f8430ef Compare March 23, 2024 18:15
}
}

public void setGroupIdPattern(String groupIdPattern) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setters methods are not required

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwin kwin merged commit 80ee78e into master Apr 4, 2024
49 checks passed
@kwin kwin deleted the feature/require-matching-coordinates branch April 4, 2024 18:45
<rules>
<requireMatchingCoordinates>
<groupIdPattern>com\.example.\namespace\..*</groupIdPattern>
</requireTextFileChecksum>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants