Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-292] Fix configuration name in documentation to match with actual name #217

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

caiwei-ebay
Copy link
Contributor

@caiwei-ebay caiwei-ebay commented Nov 10, 2022

As discussed in https://issues.apache.org/jira/browse/MNG-5896, the param in code does not match with the one in doc:
https://maven.apache.org/resolver/configuration.html

DOC: aether.dependencyCollector.impl
Code: aether.collector.impl


https://issues.apache.org/jira/browse/MRESOLVER-292

@caiwei-ebay
Copy link
Contributor Author

caiwei-ebay commented Nov 10, 2022

@michael-o @cstamas

Please help check.

@cstamas cstamas added this to the 1.9.1 milestone Nov 11, 2022
@cstamas cstamas changed the title fix param does not match with doc [MRESOLVER-292] Fix configuration name in documentation to match with actual name Nov 11, 2022
@caiwei-ebay
Copy link
Contributor Author

caiwei-ebay commented Nov 11, 2022

@cstamas

Thanks for the review.
Looks like 1.9.0 was not released successfully, would you please retry the 1.9.0 release or 1.9.0 will be skipped and 1.9.1 will be the next version? Just hoping people could try out and feedback with 1.9.0 at the earliest.

@cstamas
Copy link
Member

cstamas commented Nov 12, 2022

Thanks for the review. Looks like 1.9.0 was not released successfully, would you please retry the 1.9.0 release or 1.9.0 will be skipped and 1.9.1 will be the next version? Just hoping people could try out and feedback with 1.9.0 at the earliest.

What do you mean by "1.9.0 was not released successfully"? It is out there on Central, and even Maven PR now successfully use it? apache/maven#831

@cstamas
Copy link
Member

cstamas commented Nov 12, 2022

1.9.1 release is planned, so far 3 PRs https://github.com/apache/maven-resolver/milestone/1

@caiwei-ebay
Copy link
Contributor Author

@cstamas Saw the jars in Central and docs updated: https://maven.apache.org/resolver/configuration.html#. Thanks!

@cstamas cstamas merged commit e1b5ab9 into apache:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants