[MRESOLVER-220] Refuse proactively unsupported operation #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead to silently "send result" (that is false) to caller, as this makes totally strange outcome: "failed to lock within 30sec" but caller did not wait anything. Moreover, the bug where upgrade is attempted slips in unnoticed. --- https://issues.apache.org/jira/browse/MRESOLVER-220
Fix "do not retry" case.
gnodet
approved these changes
Jun 20, 2023
...st/java/org/eclipse/aether/internal/impl/synccontext/NamedLockFactoryAdapterTestSupport.java
Outdated
Show resolved
Hide resolved
...ast/src/test/java/org/eclipse/aether/named/hazelcast/NamedLockFactoryAdapterTestSupport.java
Show resolved
Hide resolved
Signed-off-by: Tamas Cservenak <tamas@cservenak.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead to silently "send result" (that is false/code expect true=success) to caller, as this makes totally strange outcome: "failed to lock within 30sec" but caller did not wait anything. Moreover, the bug where upgrade is attempted slips in unnoticed.
In short: it was totally wrong that lock implementation immediately returns "false", hiding the fact that user attempted non supported operation.
https://issues.apache.org/jira/browse/MRESOLVER-220