Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSITE-1012] Clean up notion that sites aren't deployed to repositories #195

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

michael-o
Copy link
Member

This closes #195

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSITE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSITE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and to align the topic about the non existing site repository term in other places of the plugin. I'm not an official commiter, so I don't know if another person has to accept your changes too. Nevertheless you get an "accept" from me 👍

One thing as I don't know yet how deprecation of attributes is handled in Maven: 1) We could create an issue for the actual removal to have this topic on the list (regardless of the moment it will be done). 2) Shall we (Can we technically) add a warning in the console so the user gets notified that he/she is using a deprecated configuration property?

@michael-o
Copy link
Member Author

You are right, will split it to make it visible.

@michael-o
Copy link
Member Author

@Bukama Split into to issues.

@asfgit asfgit merged commit 170efdb into master Jul 9, 2024
54 checks passed
@michael-o michael-o deleted the MSITE-1012 branch July 9, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants