This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
Workaround for fieldnames with dots in elasticsearch #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2020 15:29
… indexed by Elasticsearch which contains dots in its fieldnames. Note that this is actually caused by Elasticsearch, because the mapping returned for such a document by Elasticsearch doesn't match the source returned by Elasticsearch when getting the source of a search hit. (see elastic/elasticsearch-hadoop#853 and related issues for more info on this).
…based on indexed documents with dots in the field names in an inconsistent manner. I.e the mapping it returns for such documents indicate those kind of fields are treated as nested objects. But if you get the source map of such a document from Elasticsearch, it still contains the original fieldnames (with dots in them).
jhorcicka
reviewed
Jul 6, 2020
| } else if (column.getType() == ColumnType.MAP && value == null) { | ||
| // Because of a bug in Elasticsearch, when field names contain dots, it's possible that the | ||
| // mapping of the index described a column to be of the type "MAP", while it's based on a number | ||
| // of fields contains dots in their name. In this case we may have to work around that |
There was a problem hiding this comment.
"contains dots..." => "containing dots..."
added 3 commits
July 7, 2020 07:57
…ith-dots-in-elasticsearch
…ith-dots-in-elasticsearch
kaspersorensen
approved these changes
Jul 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaModel is unable to work with a document indexed by Elasticsearch which contains dots in its field names. Note that this is actually caused by Elasticsearch, because the mapping returned for such a document by Elasticsearch doesn't match the source returned by Elasticsearch when getting the source of a search hit. (see elastic/elasticsearch-hadoop#853 and related issues for more info on this).
Note that the branch for this PR is branch off of the branch for #242, because it extends the Integration Test which is introduced in that PR.