Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow bk cluster init to restart on failure (#303)
### Motivation This is essentially the same as #176. Without this change, an init pod can fail and be in `Error` state even though the second pod succeeded. This will prevent misleading errors. ### Modifications * Replace `Never` with `OnFailure` ### Verifying this change This is a trivial change.
- Loading branch information
48501eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match #176, I think it would be necessary to remove
|| yes
frompulsar-helm-chart/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
Line 73 in 48501eb
(That is a code path that is taken only when
metadataPrefix
is set.)48501eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you for your review. I'll submit a PR to update it.